-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: upgrade dependencies #297
Conversation
This is work in progress
|
When you are done with this, can you do an update package per commit? It is a blob change anyway, however, if you wait #292 this should be way simple because there are less packages that depends from |
c9218da
to
5c469c5
Compare
Last steps rust-bitcoin/rust-bitcoin#3668 |
5c469c5
to
aa8aee6
Compare
lightning 0.0.123 -> 0.0.125 bitcoin 0.30 -> 0.32
bitcoincore-rpc 0.17 -> 0.19
bitcoincore-rpc 0.17 -> 0.19 bitcoin-hashes 0.12 -> 0.15
aa8aee6
to
c5874f6
Compare
Some tests are failing
|
c5874f6
to
ac3b448
Compare
Fixed the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
I am added some basic comment, and I think this PR should be based in on the next
branch because it is much cleaner.
Or you can build on top of the first comment of the following PR https://github.com/vincenzopalazzo/lampo.rs/pull/292/commits (ONLY the first commit, so you can cherry-pick it)
other_key: &lightning::bitcoin::secp256k1::PublicKey, | ||
tweak: Option<&lightning::bitcoin::secp256k1::Scalar>, | ||
) -> Result<lightning::bitcoin::secp256k1::ecdh::SharedSecret, ()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here we do not referer in this crate with lightning
, it is wrong.
Please see how we use it in other part of the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -17,6 +17,7 @@ pub mod request { | |||
pub use crate::model::getinfo::*; | |||
pub use crate::model::invoice::request::*; | |||
pub use crate::model::keysend::request::*; | |||
#[allow(unused_imports)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is wrong, why we are using it? you are suppressing warning and we should not do without a good reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The network request has nothing in it.
pub mod request {} |
We could probably remove this, but then the request and response pattern would be non-uniform.
This is having many conflicts with the next branch if I am rebasing it (mainly because of main and next branch conflict), I'll reopen this |
Opened in #314 |
LDK 0.0.123 -> 0.0.125
bitcoin 0.30 -> 0.32 (as LDK uses 0.32)
bitcoincore_rpc 0.17 -> 0.19